Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix matrix_locations when used in pbf request #3997

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

dnesbitt61
Copy link
Member

@dnesbitt61 dnesbitt61 commented Mar 1, 2023

Issue

fixes #3996

Needed to use one_of in options.proto and check has_matrix_locations_case() in the else case so we do not overwrite a properly set matrix_locations value in the incoming pbf request.

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

nilsnolde
nilsnolde previously approved these changes Mar 1, 2023
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice, you're the first known (to me) to use the PBF interface!

I'm indifferent to changelog.

@kevinkreiser
Copy link
Member

if its not too much trouble i think bug fixes are very good candidates for the changelog.

pbf support is a first class citizen, i can tell you that huge numbers of people rely on it daily.

@dnesbitt61 dnesbitt61 merged commit 7667235 into master Mar 1, 2023
@dnesbitt61 dnesbitt61 deleted the matrix_locations_proto branch March 1, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matrix_locations overwritten when set in pbf requests
3 participants