throw on duplicated names for recostings #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
| Api api; | ||
| auto json = actor.route(R"({"costing":"auto","locations":[)" + locations + R"(],"recostings":[ | ||
| {"costing":"auto","name":"same"}, |
There was a problem hiding this comment.
just a note. i know that the base costing doesnt serialize its name in the attributes that come out but if you do name it the same as a recosting it is kind of strange.
kevinkreiser
approved these changes
Mar 27, 2023
|
I don’t trust codecov anymore.. why is it reporting from inside test files? Doesn’t make much sense to me.. Often it also seems to be pretty erratic.. anyways, I know it’s not easy to do. |
|
Or is it a config issue to some degree? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4041
Chose to throw when there'd be dups.