added transit level to connectivity map #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Apr 22, 2023
| if (!connectivity_map) { | ||
| continue; | ||
| } | ||
| auto colors = connectivity_map->get_colors(TileHierarchy::levels().back().level, correlated, 0); | ||
| auto colors = connectivity_map->get_colors(connectivity_level, correlated, connectivity_radius); |
There was a problem hiding this comment.
pass the full TileLevel, we need access to level 2 or 3 tiles and need to know which level it was
nilsnolde
commented
Apr 22, 2023
| EXPECT_NE(conn.get_color({a2, 2, 0}), conn.get_color({d0, 2, 0})) << "a is disjoint from d"; | ||
|
|
||
| filesystem::remove_all(tile_dir); | ||
| for (const auto& level : {TileHierarchy::levels()[2], TileHierarchy::GetTransitLevel()}) { |
There was a problem hiding this comment.
just added the for loop, nothing else
There was a problem hiding this comment.
ah and passing the level to the touch_tile function
kevinkreiser
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To compare colors for transit, we look at level 3 colors but within
transit_start_end_max_distancemeters of correlated edges, which are still missing the transit connection edges. We wanted to eventually add support for that for multiple reasons anyways: start the journey on such an edge and also to return departure info for/locate. For the connectivity map it's not so bad, at least with the defaulttransit_start_end_max_distance.Also lets us determine whether transit tiles are loaded with less resources than currently in #4062.