fix crash in timedistancebssmatrix.cc #4244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
reviewed
Aug 9, 2023
| @@ -99,8 +99,7 @@ void TimeDistanceBSSMatrix::Expand(GraphReader& graphreader, | |||
| const DirectedEdge* opp_edge = nullptr; | |||
| if (!FORWARD) { | |||
| // Get opposing edge Id and end node tile | |||
| graph_tile_ptr t2 = | |||
kevinkreiser
approved these changes
Aug 9, 2023
vesperlou
pushed a commit
that referenced
this pull request
Aug 25, 2023
* fix crash in timedistancebssmatrix.cc * update changelog.md
eikes
pushed a commit
to eikes/valhalla
that referenced
this pull request
Aug 28, 2023
* fix crash in timedistancebssmatrix.cc * update changelog.md
kevinkreiser
added a commit
that referenced
this pull request
Sep 6, 2023
* skeleton for updates to the tile structure * update AddLandmark * fix bugs and code cleaning * add string_to_landmark and vice versa in landmark header * move stuff into baldr * more structure to the test * update Landmark back to struct * update get_landmarks_by_bbox arguments order * problem: sanity checks failed * update Landmark::from_str to constructor * fix encode and decode of lng and lat for landmark * fix typo and argument names * fix null byte bug by updating encoding of Landmark objects * failing test * some ramblings about how to get the data in ther * back to fixed length encoding of Landmark lat and lng; update EdgeInfo::GetTaggedValues and EdgeInfo::GetTags() * fix bug and allow more landmark tests * tidy * fix bug * remove repeated imports * update changelog * use std::move and add to landmark test * fix crash in timedistancebssmatrix.cc (#4244) * fix crash in timedistancebssmatrix.cc * update changelog.md * fix up Cmake/protobuf disaster (#4207) * use protobuf's CMake config instead of CMake's own * add todo * ugly workaround * manually find & link abseil to protobuf * changelog * comment out the dll line * boil down to linking only the used abseil library * address code review * complete test * fix: links on the optimized route API document (#4260) * fix: links on the optimized route API document * docs: updated changelog * skeleton for adding landmarks to the tiles * more skeleton comments * Update landmarks.cc * more draft * finish landmarks.cc and resolve compilation issues * issue to be fixed * bug: landmark added twice. the repeated landmark is always the last one to be added. NOTE: GraphTileBuilder::AddName cannot recognize the 'same' string. This bug is also correlated with landmark name size. * fix bug and more tests * fix bug of repeats and clean up code * fix typo * add a search cutoff for landmarks, and update tests * add error test and use std::move in edgeinfo_offset_map_ update * address code reviews and add comments * update Changelog * small update on const variable and tests * add funciton description * quick update --------- Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com> Co-authored-by: Patrick Qian <patrick.qian@kisio.com> Co-authored-by: Nils <nilsnolde@proton.me> Co-authored-by: Pranav Chatly <pchatly786@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
fix crash in
timedistancebssmatrix.ccTasklist