removed clear_heading while sanitizing in loki_worker_t #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems the tests pass at least. Unless someone has objections, I'd merge this. @dnesbitt61 or @kevinkreiser ? Can you also update the changelog in the BUG FIX section @jehamannco ? New items go to the bottom of the list. |
|
Seems fine to me. I've used this in our fork of Valhalla for quite a while with one to many matrices, so no objection from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR targets issue #1802. Here the heading information was erased during matrix calculation. This aim to keep the heading data.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?