few matrix serializer fixes #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Oct 28, 2023
nilsnolde
commented
Oct 28, 2023
Comment on lines
+109
to
+111
| auto& corr_ll = location.correlation().edges(0).ll(); | ||
| input_locs->emplace_back(json::map( | ||
| {{"lat", json::fixed_t{corr_ll.lat(), 6}}, {"lon", json::fixed_t{corr_ll.lng(), 6}}})); |
There was a problem hiding this comment.
changing it to only one correlated edge in the sources & targets response arrays
dnesbitt61
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should've walked away when I had the chance.. mostly I'm to blame for these fixes here:
add aI'll revert that for now. I had complaints about bloating the "slim" matrix from clients.date_timesarray to the response of a "slim" matrix (i.e.verbose=false) in case there was any datetimesources&targetsarrays in the response contained all correlated points of all edges and of course tons of duplicates, so here I change it to only return the first correlated edge