Fix ferry shortest path recovery #4378
Commits on Nov 2, 2023
-
Add test that demonstrates the wrong path can be recovered from the
ShortestPath method in ferry_connections.cc
-
Fix the last_label_idx - make sure it is only set when an edge with the
target classification (or better) is present at the node being expanded. Identify cases where no reclassification occurs (e.g,. islands with no edges that meet the target classification) and log the locations.
-
-
Add test to make sure no edges are reclassified if the target
classification is not found.
-
Looks like ReclassifyFerryConnections automatically sets the first edge
connecting to the ferry to primary. I added a test to make sure no edges are reclassified if no edges with the target classification are encountered. However, the initial ferry connection edge is set to primary even if no edges with the target classification are encountered in ShortestPath.
Commits on Nov 3, 2023
-
-
remove some method declarations - not needed since only used in
ferry_connections.cc.
-
More properly identify cases where no paths to/from ferries to target
classification roadways exist.
-
-
-
Remove the check if node_labels.size == 0. This is redundant now that we
check for a valid last_label_idx being set.
Commits on Nov 7, 2023
-
-
Merge remote-tracking branch 'origin/fix_ferry_shortestpath' into fix…
…_ferry_shortestpath
-
Modify the nothing reclassified test to remove the first edge connected
to the ferry. No longer upclassed if no path to higher class edges is found.