-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove needs_ci_run script #4423
Conversation
delete it.. |
aab3653
to
fb513f1
Compare
deleted the script instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i hate precommit hooks but since circle doesnt support a list of paths that should skip ci but it does support skipping ci via the commit message we could make a custom commit hook that fails if:
- the only changes happening are on files in paths marked unimportant for ci AND
- if the commit message doesnt have the
[skip ci]
string in it
this would at least trigger a person to think oh yeah i should skip ci here. problem is it wo uld only help people who use precommit which is probably not everyone.
i personally like it simple with no trickery regarding should or shouldnt build a commit
That’d be fine too. I once customized a git command to “git draft” which automatically prepended “skip ci” but I never remembered to use it. It’s more transparent than a commit hook, but we can’t do that for people, they’ll have to do that. A quick and simple commit hook would go a long way for myself at least. |
it's failing again becauserequests
isn't installed. let's remove it completely to remove that headache. it's not even simplifying things in this script, so it's really just overhead.instead I removed it, it's breaking all the time silently and has hardly any impact even when it's working..