Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove needs_ci_run script #4423

Merged
merged 7 commits into from
Dec 28, 2023
Merged

remove needs_ci_run script #4423

merged 7 commits into from
Dec 28, 2023

Conversation

nilsnolde
Copy link
Member

@nilsnolde nilsnolde commented Nov 30, 2023

it's failing again because requests isn't installed. let's remove it completely to remove that headache. it's not even simplifying things in this script, so it's really just overhead.

instead I removed it, it's breaking all the time silently and has hardly any impact even when it's working..

scripts/needs_ci_run Outdated Show resolved Hide resolved
@nilsnolde
Copy link
Member Author

delete it..

@nilsnolde nilsnolde changed the title remove requests from the needs_ci_run script to ease usage remove needs_ci_run script Dec 28, 2023
@nilsnolde
Copy link
Member Author

deleted the script instead

Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate precommit hooks but since circle doesnt support a list of paths that should skip ci but it does support skipping ci via the commit message we could make a custom commit hook that fails if:

  1. the only changes happening are on files in paths marked unimportant for ci AND
  2. if the commit message doesnt have the [skip ci] string in it

this would at least trigger a person to think oh yeah i should skip ci here. problem is it wo uld only help people who use precommit which is probably not everyone.

i personally like it simple with no trickery regarding should or shouldnt build a commit

@nilsnolde
Copy link
Member Author

nilsnolde commented Dec 28, 2023

That’d be fine too. I once customized a git command to “git draft” which automatically prepended “skip ci” but I never remembered to use it. It’s more transparent than a commit hook, but we can’t do that for people, they’ll have to do that. A quick and simple commit hook would go a long way for myself at least.

@nilsnolde nilsnolde merged commit ae8cb68 into master Dec 28, 2023
9 checks passed
@nilsnolde nilsnolde deleted the nn-remove-requests branch December 28, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants