Do not reclassify ferry connections when hierarchy=false #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
being used. Add a log statement to indicate no reclassification is occurring in the case where mjolnir config has hierarchy set to false.
this method in case turn channels are being inferred, this allows a config to have reclassify_links = false and infer_turn_channels = true. In this case, turn channels are marked but no edges are reclassified.
infer_turn_channels is true.
|
Updated so that ReclassifyLinks is called if either reclassify_links and infer_turn_channels is true in the config. Added a reclassify_links bool to ReclassifyLinks (and pass this through to ReclassifyLinkGraph). If this is false, no edges are reclassified (but can be used for infer_turn_channels). |
dnesbitt61
changed the title
kevinkreiser
previously approved these changes
Jan 10, 2024
|
I copied the TEST(RampsTCs, test_tc_infer) test and changed so that reclassify_links is false and infer_turn_channels is true. The test checks the ramps classification (makes sure they stay as motorway). Edge GK seems to still be marked as internal and a turn channel (as before). However, the narrative checks fail now. I am not sure why! |
not a ramp and not a turn channel, since we can have motorway ramps that are marked as turn channels (if reclassify_links is false and infer_turn_channels is true).
or a turn channel.
kevinkreiser
previously approved these changes
Jan 10, 2024
kevinkreiser
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not reclassify ferry connections if hierarchies are not being used. Add a log statement to indicate no reclassification is occurring in the case where mjolnir config has hierarchy set to false.
Update graphbuilder to call link reclassification if infer_turn_channels is true. However, if reclassify_links is false then the actual reclassification (changing an edges classification) is bypassed but turn channel generation is performed (if config indicates infer_turn_channels=true).
fixes #4486
Log statements from a Maryland build where infer_turn_channels=true, reclassify_links=false, and hierarchy=false:
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?