Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bench #4560

Merged
merged 20 commits into from
Feb 11, 2024
Merged

remove bench #4560

merged 20 commits into from
Feb 11, 2024

Conversation

nilsnolde
Copy link
Member

fixes #4557

based on #4554

removes the ./bench and everything related (CMake flags, CI jobs etc).

kevinkreiser
kevinkreiser previously approved these changes Feb 11, 2024
Copy link
Member

@kevinkreiser kevinkreiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels great to shed this

@nilsnolde
Copy link
Member Author

No idea why the win ci is flaky..

@nilsnolde nilsnolde merged commit ba5730e into master Feb 11, 2024
7 of 9 checks passed
@nilsnolde nilsnolde deleted the nn-remove-benchmarks branch February 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "benchmarks" from CI?
2 participants