Allow all ores in blast furnace #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValheimPlus/ValheimPlus.csproj
Outdated
| @@ -40,47 +40,47 @@ | |||
| <HintPath>..\packages\HarmonyX.2.3.1\lib\net35\0Harmony.dll</HintPath> | |||
| </Reference> | |||
| <Reference Include="assembly_googleanalytics_publicized"> | |||
| <HintPath>$(VALHEIM_INSTALL)\valheim_Data\Managed\publicized_assemblies\assembly_googleanalytics_publicized.dll</HintPath> | |||
| <HintPath>..\..\..\..\..\..\Program Files (x86)\Steam\steamapps\common\Valheim\valheim_Data\Managed\publicized_assemblies\assembly_googleanalytics_publicized.dll</HintPath> | |||
There was a problem hiding this comment.
Editing these paths will break the build for other people. Refer to step 5 of the environment setup in the CONTRIBUTING.md to see how to setup VALHEIM_INSTALL for your system.
There was a problem hiding this comment.
Wasn't paying attention when I originally set the environment variable which apparently led to this. Thanks for pointing this out!
|
Thanks for the PR @Menthus123! It looks good to me but could you squash your commits? The amount/type of changes done in each of them do not warrant such details. Another thanks for the curly bracket, saw it after rebasing onto my fork. This specific commit could be kept thou since it might make things easier when rebasing/merging. |
MarvelProgramming
force-pushed
the
AllowAllOresInBlastFurnace
branch
3 times, most recently
from
95c0af4
to
eb52ebe
Compare
MarvelProgramming
force-pushed
the
AllowAllOresInBlastFurnace
branch
from
eb52ebe
to
09761e6
Compare
nxPublic
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Furnace feature so users can choose whether the Blast Furnace is able to process all ores instead of just Black Metal and Flametal(was a community suggestion on https://valheim.plus/todo).