Fixing compile and patch errors introduced via v0.214.2 #793
Conversation
There was a problem hiding this comment.
I've tested a moderately modded client and server (mainly building, structural integrity, inventory, weight scaling, auto-fill stations, unlimited fire fuel, etc.) on a dedicated server with this PR fix and I can confirm I noticed ZERO issues with my V+ config.
I suggest people test this thoroughly and report back with their findings here while the main devs are inactive.
Note: If you know what you're doing, I highly suggest you checkout Grant's modifications, and build the DLL yourself if possible. Follow the updated CONTRIBUTING.md instructions.
I'm not tech savvy and I want to test the fix. How do I proceed?
For those who are willing to test (take backups of everything beforehand) and are not dev-savvy:
- Update Valheim to the latest build.
- Copy the new version of BepInEx within your Valheim/Valheim Dedicated Server folder.
Here is a zipped version of BepInEx 5.4.21 with @Grantapher Valheim Plus fix already added to the plugins folder (/BepInEx/plugins/ValheimPlus.dll): denikson-BepInExPack_Valheim-5.4.2100_ValheimPlusFix.zip.
- Backup Valheim folder.
- Update Valheim
- Download the files linked above.
- Simply open the archive and drag the content of
BepInExPack_Valheim\within your Valheim or server folder (overwrite files when prompted to). - Launch the game.
All in all, thank you very much for this PR, Grant.
|
Ill do some testing with it |
|
I was able to load V+ with the updated DLL files and the V+ screen loaded fine and it all of the config items were activated. No issues as far as I could tell. Here is the Log: [Info :Valheim Plus] ValheimPlus [0.9.9.11] is up to date. |
|
@JF10R Thanks for adding this, I was going to basically write the same instructions this morning as well so that non-devs could verify and fix their servers as well. |
|
Thanks for posting instructions, I can give them a try as well. I run my server on gportal with the vplus mod enabled -- assuming I need to push these files up to it via ftp as well? |
|
@mgan59 yes, but I'm not sure how any of the server hosts handles updates so it could get overwritten. |
|
Also, I'm running my mods all through thunderstore, to test this I need to actually replace files in my steam/valheim folder? Guess there isn't a way to target a github-branch from thunderstore -- that seems like a dream 😁 p.s. I have a dev background mainly internet software (python,golang,js) so learning my way around the unity / valheim mod stuff recently 👍🏻 |
|
on nitrado.net servers it seems not to work. even if I copy all the files into the server via FTP, the following error appears: Valheim Modded Version String Mismatch: For some reason the server is not loading valheim plus even with the updated file in the plugins folder. |
|
I am using shockbyte mods seem to be loading fine however when trying to join my world it says incompatible version someone pls help I am not tech savy myself |
|
Any incompatibilities with hosting providers should be handled by the hosting provider themselves. I'd recommend reaching out to the support for your server host, as discussion and comments on this PR should be related to the code itself, not general support updating servers. You can always join the V+ Discord for more assistance as well. |
|
Loads up fine with the patch but all tooltips are still broken. |
|
@Jadereaper do you have other mods enabled? If not, can you share a screenshot of the issue and how you can reproduce it? |
|
@Grantapher my bad, i thought i had updated Epic Loot but failed to copy it into the folder. Everything is working fine atm. |
|
@everyone who is testing this and considers themselves "not-tech-savvy": Please note that you need the new BepInEx and Valheim Plus version on both server + client. I also did some basic tests last night and can confirm that it is generally working. Not many options are enabled on our server, but the clock (game time) is shown and the "Free rotation mode" (1 degree rotation for all axis) is possible. |
|
My anti virus was triggered by valheimplus.dll. Anyone else received a warning message regarding this? |
|
I tested yesterday all V+ settings. |
My first guess is that your antivirus has a signature for ValheimPlus.dll version 0.9.9.1.1, which is mismatched with this new, modified DLL. Thus triggering an alert. Or follow the guide linked above and build it yourself, which is always the safest option. If you are still on the fence, which I would completely understand, I strongly recommend you wait for the official release and not trust the word of a stranger on the web :) Stay safe. (For other devs reading this: I simply built the PR 793 version of the solution as-is on VS2022 Community Edition and added it to the official BepInEx zip archive) |
|
I would be concerned if anti-virus didn't flag random DLLs ha. If you want to be extra safe, you can checkout the PR and build it yourself. Instructions on how to set it up the dev env are here. Then install visual studio 2022, open the |
I downloaded this zip file and tested it with my G Portal server. Here is what I did: I used these folders and files from the zip:
Server side: FTP into the server and copy the above folders and files into the root directory, delete old or overwrite existing folders and files if prompted. If you have a V+ config you have been using, replace the BepInEx/config/valheim_plus.cfg with your config. Client side: Copy/paste the folders and files above into your Valheim game directory, delete old or overwrite existing folders and files if prompted. For windows steam users this is likely C:\SteamLibrary\steamapps\common\Valheim. Mod appears to be working perfectly now with the changes in this PR. |
|
I take that back, even with PlanBuild disabled, I am still getting an error. |
Disregard - the issue was unrelated and was an issue with UpgradeWorld mod. |
Can confirm this patch works through Thunderstore Mod Manager, both my buddy and I tested for several hours last night on our server and all V+ functionality returned by following these steps:
Best of luck, and thank you @Grantapher & @JF10R! |
|
Anyone get this fix working on a dedicated linux server? Getting an incompatible version error when trying to connect. Thanks! |
Yes, we got it working with (more or less) the steps explained above. Make sure that you replace the ValheimPlus.dll in the plugins folder on the server AND the client. Both must be the same (from the Zip linked above). |
|
I confirm it's working with https://github.com/lloesche/valheim-server-docker with dll replacement method. Thank you! |
Me, too. You have to deactivate ValheimPlus in Environment Varaiables and to use BEPINEX=true instead. Then you copy the valheimplus.dll into the /config/bepinex/plugins folder. |
There was a problem hiding this comment.
- checked the code changes in this PR, look error-free and plausible to me
- tested the Zip provided in the PR discussion on a dedicated server plus 10 clients -> no issues, all features work like before the breaking change
=> IMHO this PR is good, no reason not to merge it.
You are using Valheim PBT 0.214.300, BepInEx 5.4.2100 does not work on this version. You can find updated BepInEx on some discord servers but it has not been released on thunderstore. |
|
@Grantapher |
|
only bug fixes, don't intend on adding features. |
|
@Grantapher I was actually hoping you would include your fix for the fishing skill. #777 |
|
Yes, that is the only bug fix I have planned for the next release right now, and also the only one I am aware of. |
I have a bug, that local defined Keys will not be loaded when connecting to a dedicated server. Insted only the default values will be used. I have a fix for it, but can't commit it to your fork (branch: origin\grantapher-development). The button is disabled in VS2022. I've changed the code in BaseConfig.cs from to This is necessary to use FreePlacementRotation without colliding with other keys (e.g. F is used for activateForsaken Powers. This is very frustrating. |
|
Can you open a pr in this repo? I'll be watching this repo as well and will rebase open prs with bug fixes. Plus the owners of this repo will have to still merge it anyways. If not a pr, at least an issue. |
|
@JackTheFragger I opened the above Issue for your comment. |
|
@Grantapher with your patch on the newest update Valhein crush |
It works just fine, you have to update BepInEx |
|
@CanExiOne how do I do that? I have only ValheimPlus installed (@Grantapher patch). As far as I see BepInEx was not updated since last year |
It did, check on thunderstore https://valheim.thunderstore.io/package/denikson/BepInExPack_Valheim/ |
|
@CanExiOne thanks! Works now. I checked their repo |
|
I'll update my release and thunderstore listing later today. |
I think repackaging with newest bepinex is all that's needed. I think your fix is still good with this latest valheim update. |
|
I have Grantapher#2 queued up to be added anyways, so maybe I'll edit |
|
VPlus works without further work with 0.214.300. BepInEx has to be updated only. For llloesche/valheim-server you have to update the bepinex.cfg manually. Issue opened: lloesche/valheim-server-docker#608 |
Possibly fixes #789, #790, #791, #792. Unclear if there are any incompatibilities in
Valheim v0.214.2that didn't cause obvious errors.Upgrading
BepInExPack_Valheimto5.4.2100was required. Without it, there were additional errors when using the console or chat, seemingly because of missingunstripped_corlibdependencies that were added in the new Valheim version.I tested the use cases mentioned not working in the linked issues with some exceptions:
Given that most of the problems were fixed from changes in mostly unrelated code, I think it is not terribly risky to say it was the root cause.
Edit: Since this seems like it may be sitting a while, I uploaded this change to thunderstore for folks who install from there and added a release on my fork for folks who install manually. The regular installation instructions will apply to that release.
They both contain one additional change that bumps up the version number, points some version/config checks to my fork, and adds the fact that it is not the main mod to the title screen text. The branch used is the one attached to that commit: grantapher-development.