Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<style> and <script> conformance updates #560

Closed
domenic opened this issue Sep 14, 2017 · 3 comments
Closed

<style> and <script> conformance updates #560

domenic opened this issue Sep 14, 2017 · 3 comments
Labels
spec-conformance

Comments

@domenic
Copy link

domenic commented Sep 14, 2017

whatwg/html#3024 will land soon and make a number of changes that are relevant to the checker:

  • More clearly require checkers to emit warnings for <script> when its type is the empty string or a JavaScript MIME type, since doing so is reundant.
  • Require checkers to emit warnings for <style> when its type attribute is specified at all.
  • Remove the requirement on <style> text content prohibiting unmatched comment syntax (previously specified with an ABNF)
  • Add the requirement that <style> text content be valid parseable CSS (this will be a fun one to implement for you, I am sure :) )
sideshowbarker added a commit that referenced this issue Nov 30, 2017
@sideshowbarker
Further restrict script[type]
782c84b 
Addresses #560
sideshowbarker added a commit that referenced this issue Nov 30, 2017
@sideshowbarker
Further restrict style[type]
983a05a 
Addresses #560
@sideshowbarker
Copy link
Contributor

  • More clearly require checkers to emit warnings for <script> when its type is the empty string or a JavaScript MIME type, since doing so is reundant.

Fixed in 782c84b

  • Require checkers to emit warnings for <style> when its type attribute is specified at all.

Fixed in 983a05a

Pushed both fixes to https://checker.html5.org/

sideshowbarker added a commit that referenced this issue Dec 5, 2017
@sideshowbarker
Check that style elements’ contents are valid CSS
d954e3c 
This change integrates the same backend code from the W3C CSS Validator
to add checking for the contents of each `style` in a document and to
report any CSS errors encountered.

Addresses #560
@sideshowbarker
Copy link
Contributor

  • Add the requirement that <style> text content be valid parseable CSS (this will be a fun one to implement for you, I am sure :) )

Fixed in d954e3c and pushed to https://checker.html5.org/

@annevk annevk mentioned this issue Dec 6, 2017
Closed
@sideshowbarker
Copy link
Contributor

I think all changes for this have been merged but if I missed anything, lemme know

@dmtucker dmtucker mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec-conformance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sideshowbarker @domenic