Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isMACAddress does not allow use of - instead it only uses : for example A9-C5-D4-9F-EB-D3 is invalid #1061

Closed
ezkemboi opened this issue Jul 12, 2019 · 2 comments
Labels

Comments

@ezkemboi
Copy link
Member

When doing validation of MACAddress it does not allow the use of - for separation.
For example, when I pass A9-C5-D4-9F-EB-D3, it will be invalid mac address.
But, when I pass it as A9:C5:D4:9F:EB:D3.
I don't know if there is a reason why we only allow : and not including -?

@profnandaa
Copy link
Member

Just checked here, and I agree with this. You can send a fix?

@ezkemboi
Copy link
Member Author

Alright, I will send it @profnandaa.

ezkemboi added a commit to ezkemboi/validator.js that referenced this issue Jul 20, 2019
- Authoured_by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
- Closes validatorjs#1061
ezkemboi added a commit to ezkemboi/validator.js that referenced this issue Jul 22, 2019
- Authoured_by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
- Closes validatorjs#1061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants