Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isDate() #1130

Closed
rubiin opened this issue Oct 5, 2019 · 15 comments · Fixed by #1270
Closed

isDate() #1130

rubiin opened this issue Oct 5, 2019 · 15 comments · Fixed by #1270

Comments

@rubiin
Copy link
Member

rubiin commented Oct 5, 2019

I noticed there is no validator such as isDate() . It was removed in previous version. It would be handy to have a validator that checks date only unlike the datestring.
For example, 2018/08/09 , 1988-07-18

@profnandaa
Copy link
Member

I think there was a reason this was removed, we'll need to check the archives...

@rubiin
Copy link
Member Author

rubiin commented Oct 5, 2019

@profnandaa It would be nice to have a validator for a simple use case as i mentioned above

@profnandaa
Copy link
Member

Sure, please make a PR and we could pick up from there. I don't want to be blocking. Also check isISO8601(str) while doing that.

@profnandaa
Copy link
Member

/cc. @chriso

@ezkemboi
Copy link
Member

ezkemboi commented Oct 6, 2019

I will look also on some archived PRs that had previously addressed the issue of isDate()

@Rye-Guy
Copy link

Rye-Guy commented Oct 7, 2019

I would like to work on this issue as a part of my hacktoberfest contributions. If this is still being investigated I can move on to another.

@profnandaa
Copy link
Member

profnandaa commented Oct 8, 2019 via email

@MeghaMehrotra
Copy link

Added Date Validation PR #1170

@artorias111
Copy link

Hey! I can work on this issue if no one else is working on it right now.

@profnandaa
Copy link
Member

@artorias111 -- I don't think anyone else is working on it, please go ahead.

/cc. @chriso -- any history lesson on why isDate was deprecated?

@mum-never-proud
Copy link
Contributor

please have a look at the PR, I am in need of this implementation thought of doing it let me know if any changes are needed

thanks!

@rkoziel
Copy link

rkoziel commented Mar 30, 2020

Is the isDate() validator now available to use? I am needing this validation for a project I am currently working on.

@profnandaa
Copy link
Member

@rkoziel -- currently in review #1270

@rkoziel
Copy link

rkoziel commented Mar 31, 2020

Is there an ETA on when this may be available?

@profnandaa
Copy link
Member

@rkoziel -- best bet, (end of) April release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants