Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isBase64Url() #1212

Closed
tmikaeld opened this issue Dec 8, 2019 · 11 comments · Fixed by #1277
Closed

isBase64Url() #1212

tmikaeld opened this issue Dec 8, 2019 · 11 comments · Fixed by #1277

Comments

@tmikaeld
Copy link

tmikaeld commented Dec 8, 2019

Feature request.

@profnandaa
Copy link
Member

PR welcome!

@rubiin
Copy link
Member

rubiin commented Dec 15, 2019

I like to look into this one

@tmikaeld
Copy link
Author

Seems that using a simple /^[A-Za-z0-9\-_]+$/regex for this is common.

I'm unaware of any other pattern to follow here.

@rubiin
Copy link
Member

rubiin commented Dec 15, 2019

@tmikaeld correct me if i am wrong but this does look like the issue. If it is, i will get working hapijs/joi#1746

@rubiin
Copy link
Member

rubiin commented Dec 28, 2019

@profnandaa can i do a pr?

@profnandaa
Copy link
Member

profnandaa commented Dec 28, 2019 via email

@rubiin
Copy link
Member

rubiin commented Dec 29, 2019

this Pr resolves this #1223

@mum-never-proud
Copy link
Contributor

mum-never-proud commented Mar 31, 2020

@profnandaa I couldn't find a method with this name, has it been renamed or yet to be implemented?

would raise a pr if not already implemented

@tmikaeld
Copy link
Author

@mum-never-proud Doesn't seem to be implemented, the PR that's been merged seem to be empty. Since the ball has been dropped, feel free to make a new PR.

@profnandaa
Copy link
Member

Sure.

@mum-never-proud
Copy link
Contributor

cool, I have raised the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants