Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug version 13.5.0 with webpack #1538

Closed
kevoj opened this issue Nov 30, 2020 · 7 comments
Closed

Bug version 13.5.0 with webpack #1538

kevoj opened this issue Nov 30, 2020 · 7 comments
Labels
🐛 bug

Comments

@kevoj
Copy link

kevoj commented Nov 30, 2020 •
edited

Bug version 13.5.0 with webpack (version 13.1.17 works fine)

image

webpack: 5.9.0
Validator.js version: 13.5.0
Node.js version: 10.21.0
OS platform: [linux]
@kevoj kevoj added the 🐛 bug label Nov 30, 2020
@kevoj kevoj changed the title Bug with webpack Bug version 13.5.0 with webpack Nov 30, 2020
@fedeci
Copy link
Contributor

fedeci commented Nov 30, 2020

This is also happening to me, I believe it is due to the deletion of index.js in #1528

@smart-apeha
Copy link

Same for me! rename validator.js to index or change "main" entry in package.json

@fedeci
Copy link
Contributor

fedeci commented Nov 30, 2020

I am opening a PR hoping it will be accepted soon.

@profnandaa
Copy link
Member

On it, fixing. Sorry about that.

@fedeci fedeci mentioned this issue Nov 30, 2020
Closed
3 tasks
@profnandaa
Copy link
Member

Please check if 13.5.1 patch is good; really sorry for breaking you folks, we do our builds on local machine for now, but we will try and automate.

@profnandaa profnandaa mentioned this issue Nov 30, 2020
Closed
@kevoj
Copy link
Author

kevoj commented Nov 30, 2020

Please check if 13.5.1 patch is good; really sorry for breaking you folks, we do our builds on local machine for now, but we will try and automate.

13.5.1 works fine! Thanks for your help, somehow we are testers in other environments :)

@kevoj kevoj closed this as completed Nov 30, 2020
@profnandaa
Copy link
Member

Nice, thanks! We'd ignored the index.js but I think we will just bring it back to prevent such slips.

profnandaa added a commit that referenced this issue Dec 1, 2020
@profnandaa
fix: update v on changelog
0b0b4e9 
we recalled 13.5.0 due to build issues #1538 #1537
This was referenced Mar 12, 2021
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: reset gitignore to before #1528 fedeci/validator.js
4 participants
@profnandaa @smart-apeha @kevoj @fedeci