Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isHash returns false for upper case hashes #987

Closed
itaychi opened this issue Feb 24, 2019 · 2 comments
Closed

isHash returns false for upper case hashes #987

itaychi opened this issue Feb 24, 2019 · 2 comments
Labels
pr-raised

Comments

@itaychi
Copy link

itaychi commented Feb 24, 2019 •
edited

isHash returns false if hash is upper case.
cause is that the regex checking hashes does not contain upper case characters.
I created a pull request #982 with an update to the regex that evaluates hashes.
ezkemboi added a commit to ezkemboi/validator.js that referenced this issue Jul 13, 2019
@ezkemboi
Clean PR on allow uppercase for isHAsh
67b22b4 
- Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
- Closes validatorjs#982 validatorjs#987
profnandaa pushed a commit that referenced this issue Jul 24, 2019
@ezkemboi @profnandaa
fix(isHash): to include uppercase chars in hash (#1062)
cf00ee6 
* change hash test regex to include uppercase chars

* Clean PR on allow uppercase for isHAsh
- Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
- Closes #982 #987
@ezkemboi
Copy link
Member

This issue is solved. Need to be closed.

cc. @itaychi and @profnandaa.

@profnandaa
Copy link
Member

closed in #1062

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr-raised
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@profnandaa @itaychi @ezkemboi