Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add es-AR locale (Argentina) #1444

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

csrgt
Copy link
Contributor

@csrgt csrgt commented Sep 19, 2020

Argentine phone numbers can be quite varied I found, thankfully mobile phone numbers are more straightforward, I also consulted with some argentinian friends to make sure my regex was working as intended! 馃槃

@codecov
Copy link

codecov bot commented Sep 19, 2020

Codecov Report

Merging #1444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1444   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           95        95           
  Lines         1256      1256           
=========================================
  Hits          1256      1256           
Impacted Files Coverage 螖
src/lib/isMobilePhone.js 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0f7739a...c26da0f. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contrib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants