added isTime validator #1479
Merged
added isTime validator #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 26dbbe7.
|
@francoatmega please fix the tests |
|
After several tries, I have no idea why the tests no pass...
|
profnandaa
added
the
🧹 needs-update
|
This probably will solve issue #1403 |
|
Thanks for your PR! 🎉 Please fix the merge conflicts. |
|
@francoatmega -- ping |
|
Fix the merge conflicts if there are any and make sure to pass all tests |
Codecov Report
@@ Coverage Diff @@
## master #1479 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 105 +1
Lines 2203 2211 +8
Branches 477 478 +1
=========================================
+ Hits 2203 2211 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Some one can check this? All tests passed except for one nos seems to be problems um dependencies. @profnandaa @rubiin |
fedeci
reviewed
Feb 12, 2021
Co-authored-by: Federico Ciardi <fed.ciardi@gmail.com>
rubiin
approved these changes
Aug 5, 2022
rubiin
added
✅ LGTM
and removed
🧹 needs-update
francoatmega
requested review from
fedeci and
rubiin
and removed request for
fedeci
rubiin
approved these changes
Aug 13, 2022
profnandaa
approved these changes
Dec 12, 2022
| @@ -153,6 +153,7 @@ Validator | Description | |||
| **isUppercase(str)** | check if the string is uppercase. | |||
| **isSlug** | Check if the string is of type slug. `Options` allow a single hyphen between string. e.g. [`cn-cn`, `cn-c-c`] | |||
| **isStrongPassword(str [, options])** | Check if a password is strong or not. Allows for custom requirements or scoring rules. If `returnScore` is true, then the function returns an integer score for the password rather than a boolean.<br/>Default options: <br/>`{ minLength: 8, minLowercase: 1, minUppercase: 1, minNumbers: 1, minSymbols: 1, returnScore: false, pointsPerUnique: 1, pointsPerRepeat: 0.5, pointsForContainingLower: 10, pointsForContainingUpper: 10, pointsForContainingNumber: 10, pointsForContainingSymbol: 10 }` | |||
| **isTime(str [, options])** | Check if the input is a valid time. e.g. [`23:01:59`, new Date().toLocaleTimeString()].<br/><br/> `options` is an object which can contain the keys `hourFormat` or `mode`.<br/><br/>`hourFormat` is a key and defaults to `'hour24'`.<br/><br/>`mode` is a key and defaults to `'default'`. <br/><br/>`hourFomat` can contain the values `'hour12'` or `'hour24'`, `'hour24'` will validate hours in 24 format and `'hour12'` will validate hours in 12 format. <br/><br/>`mode` can contain the values `'default'` or `'withSeconds'`, `'default'` will validate `HH:MM` format, `'withSeconds'` will validate the `HH:MM:SS` format. | |||
There was a problem hiding this comment.
nitpick: can back-tick this too: new Date().toLocaleTimeString()
There was a problem hiding this comment.
Wondering if we could find a better way of simplifying the options 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validator for time formats.
Checklist