Add typeof utility #1648
Merged
Add typeof utility #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1648 +/- ##
==========================================
Coverage ? 100.00%
==========================================
Files ? 101
Lines ? 1851
Branches ? 0
==========================================
Hits ? 1851
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
3 tasks
tux-tn
previously approved these changes
Apr 17, 2021
profnandaa
reviewed
Apr 17, 2021
| assert.strictEqual(typeOf(null), 'null'); | ||
| assert.strictEqual(typeOf({}), 'object'); | ||
| assert.strictEqual(typeOf(new Date()), 'date'); | ||
| assert.strictEqual(typeOf('ezkemboi'), 'string'); |
There was a problem hiding this comment.
BTW, could you add one more test for String('kemboi') ?
There was a problem hiding this comment.
Added the test @profnandaa
ezkemboi
force-pushed
the
typeof-utility
branch
from
71d5a3a
to
3808d4c
Compare
|
I will try to identify the areas that this can help and see if I can create PR making those necessary changes. Cc. @profnandaa and @tux-tn |
profnandaa
approved these changes
Apr 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done
I.e type of {} == 'object' and type of null == 'null'and not that all areobject.