New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isAlpha): multiple locale support in isAlpha #1752
base: master
Are you sure you want to change the base?
feat(isAlpha): multiple locale support in isAlpha #1752
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1752 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 2015 2040 +25
Branches 454 459 +5
=========================================
+ Hits 2015 2040 +25
Continue to review full report at Codecov.
|
@fedeci please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already an opened PR #1660 for that issue, please check before creating a new one because it avoids you to lose time :)
IMHO even if it has been inactive for a while it is always better to ask before and give the user some days to answer. |
#1660 has no activity. Can this PR move forward? |
Adding support to validate an alpha string that can contain characters from multiple locales in a single instance.
resolves #1560
Checklist