Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isAlpha): multiple locale support in isAlpha #1752

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deepanshu2506
Copy link
Contributor

@deepanshu2506 deepanshu2506 commented Oct 3, 2021

Adding support to validate an alpha string that can contain characters from multiple locales in a single instance.

resolves #1560

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #1752 (a3624b0) into master (c899b31) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1752   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2015      2040   +25     
  Branches       454       459    +5     
=========================================
+ Hits          2015      2040   +25     
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)
src/lib/isAlpha.js 100.00% <100.00%> (ø)
src/lib/isEmail.js 100.00% <0.00%> (ø)
src/lib/isIdentityCard.js 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c899b31...a3624b0. Read the comment docs.

@deepanshu2506
Copy link
Contributor Author

@fedeci please review

Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already an opened PR #1660 for that issue, please check before creating a new one because it avoids you to lose time :)

@deepanshu2506
Copy link
Contributor Author

There is already an opened PR #1660 for that issue, please check before creating a new one because it avoids you to lose time :)

@fedeci there has been no activity on #1660 for quite some time now.

@fedeci
Copy link
Contributor

fedeci commented Oct 3, 2021

IMHO even if it has been inactive for a while it is always better to ask before and give the user some days to answer.

@deepanshu2506
Copy link
Contributor Author

#1660 has no activity. Can this PR move forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option for more than one locale to isAlpha
2 participants