Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isMobilePhone): add Bhutan dz-BT locale #1770

Merged
merged 6 commits into from
Oct 31, 2021
Merged

feat(isMobilePhone): add Bhutan dz-BT locale #1770

merged 6 commits into from
Oct 31, 2021

Conversation

lakshayr003
Copy link
Contributor

Worked on adding a mobile phone validation for Bhutan (dz-BT)

  1. Added validation for Bhutan mobile phone numbers
  2. Added the test for Bhutan mobile phone number validation
  3. Updated the readme to include dz-BT

@lakshayr003 lakshayr003 reopened this Oct 10, 2021
@lakshayr003 lakshayr003 mentioned this pull request Oct 12, 2021
Open
tux-tn
tux-tn previously approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thank you for your PR @lakshayr003

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed hacktoberfest-accepted labels Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021 •
edited
Loading

Codecov Report

Merging #1770 (835f27c) into master (01d3da3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1770   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2054      2054           
  Branches       464       464           
=========================================
  Hits          2054      2054
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d3da3...835f27c. Read the comment docs.

@profnandaa
Copy link
Member

@lakshayr003 - pls fix the merge conflict on README and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@lakshayr003
Copy link
Contributor Author

@profnandaa, I have resolved the merge conflict.

@profnandaa profnandaa changed the title Phone number for bhutan(+975) feat(isMobilePhone): add Bhutan dz-BT locale Oct 31, 2021
@profnandaa profnandaa merged commit fc0fefc into validatorjs:master Oct 31, 2021
@profnandaa profnandaa mentioned this pull request Oct 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

@tux-tn tux-tn tux-tn left review comments

Assignees
No one assigned
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lakshayr003 @profnandaa @tux-tn @ezkemboi