Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Russian passport number regex #1810

Merged
merged 2 commits into from
Oct 30, 2021
Merged

fix: Russian passport number regex #1810

merged 2 commits into from
Oct 30, 2021

Conversation

Theta-Dev
Copy link
Contributor

fix #1807

updated RU passport number regex to accept 9 digit numbers.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #1810 (3596b87) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1810   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isPassportNumber.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...3596b87. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for your PR @Theta-Dev 🎉

I was going to answer you concerning the white spaces. It looks like you figured out that the validator itself is stripping white-spaces before passing the string to regex and changed your regex 😃

@tux-tn tux-tn added 🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed hacktoberfest-accepted labels Oct 19, 2021
@profnandaa profnandaa merged commit de1cb29 into validatorjs:master Oct 30, 2021
theteladras pushed a commit to theteladras/validator.js that referenced this pull request Oct 30, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* fix: Russian passport number regex

fixes #1807
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
* fix: Russian passport number regex

fixes #1807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid Russian passport number regex
3 participants