A bundle of tweaks and fixes #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will work against Visa, MasterCard, American Express, Discover, Diners Club, and JCB card numbering formats.
Will work against Visa, MasterCard, American Express, Discover, Diners Club, and JCB card numbering formats.
…prototype, making them compile when the module loads rather than each time a validation function is called.Trivial clean up on in and notIn
…d up the date validation methods.
|
Has this project been deserted? |
|
@tommedema no, but providing free support to open source projects comes after my day job and all of my other work |
|
@severeon thanks for this. Any reason validator.js and validator-min.js were removed in this commit? They were separate versions for the browser |
|
These changes are exactly what I need and I'd rather not do it all myself if this commit is ok. What's the word here? |
|
That's @severeon. I did not remove the minified version; just added the validations. Pick out my commit if you just need the validations. |
|
While I was waiting for an answer I merged a similar pull request => #57 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out all the regexs and put them in Validator.prototype - allowing people to access them directly if they want, and causing them to compile only once rather than every time a validation method is used.
Added 'setMessage' to let you change your error message in the middle of a validation chain.
Optimized 'isInt' and 'isDecimal' using modulo rather than a regex.
Fixed an issue with 'isUUID' where 'pattern' was being used as a global variable rather than local.
Simplified 'isIP', 'isAfter', and 'isBefore'