Added option to validate any phone locale #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test case and also make a note in the README? Thanks. |
|
@chriso I have added tests for 'any' locale. There is also a note in README. For maintainability, I moved all valid/invalid phonenumbers in the tests into their own variables and use them when testing 'any' argument. |
|
Perfect. Thanks! |
|
Thanks! When will you do a new minor release which would include this? |
|
Probably not for a little while since I just tagged |
builtinnya
added a commit
to builtinnya/DefinitelyTyped
that referenced
this pull request
Feb 20, 2018
Locales added in v7.2: - any (validatorjs/validator.js#663) - en-KE (validatorjs/validator.js#673) - en-UG, en-RW, en-TZ (validatorjs/validator.js#676) Missing locales (but added in this commit): - da-DK (validatorjs/validator.js#601) - uk-UA (validatorjs/validator.js#585) - en-NG (validatorjs/validator.js#616) - en-PK (validatorjs/validator.js#630) - he-IL (validatorjs/validator.js#610) - ro-RO (validatorjs/validator.js#627) - zh-HK (validatorjs/validator.js#622) Non-existent locales: - fr-BE, nl-BE (validatorjs/validator.js#700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add locale option 'any'. It will pass if any of the given mobile phone locales are valid. I find it very useful in situations where users can insert just a phone number regardless of locale.