Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validating nested objects - passing the IValitator<TObject> #147

Closed
GooRiOn opened this issue Dec 9, 2017 · 4 comments
Closed

Validating nested objects - passing the IValitator<TObject> #147

GooRiOn opened this issue Dec 9, 2017 · 4 comments
Labels
1.0.0 change request
Milestone
1.0.0

Comments

@GooRiOn
Copy link
Member

GooRiOn commented Dec 9, 2017

Currently to validate a nested object we need to pass the IValitRulesProvider object to Ensure method. Actually we could pass IValitator object instead since there's no problem with that and we could simply a code even more. Honestly I don't why I didn't do this at the first time :D
@GooRiOn GooRiOn mentioned this issue Dec 9, 2017
Closed
1 task
@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 11, 2017

I'd like to pick this one. Any comments? Shall we do breaking change and switch this to pass valitators instead?

@timdeschryver
Copy link
Collaborator

I think we can afford to introduce breaking changes atm.

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 12, 2017

ok, then I'll do that !

@GooRiOn
Copy link
Member Author

GooRiOn commented Dec 12, 2017

I'll create PR tommorow

@GooRiOn GooRiOn mentioned this issue Dec 13, 2017
Merged
@GooRiOn GooRiOn added the 1.0.0 label Dec 13, 2017
@GooRiOn GooRiOn added this to the 1.3.0 milestone Dec 17, 2017
@GooRiOn GooRiOn closed this as completed Jan 2, 2018
@timdeschryver timdeschryver mentioned this issue Jan 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0.0 change request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@GooRiOn @timdeschryver