Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TD-124: Setup CI/CD with GH Actions #1

Merged
merged 22 commits into from
Feb 4, 2022
Merged

TD-124: Setup CI/CD with GH Actions #1

merged 22 commits into from
Feb 4, 2022

Conversation

keynslug
Copy link
Contributor

@keynslug keynslug commented Feb 4, 2022

  • Pull recently implemented features
  • Refactor for the elvis pleasure
  • Drop client URL logging
  • Drop geo handler and tests (TD-137)

keynslug and others added 16 commits February 4, 2022 11:28
@keynslug
Drop proprietary CI stuff
d6a9e01
@keynslug
Stop including default secret in release
8f9a369
@keynslug
Update gitignore rules
6d941c8
@keynslug
Upgrade to damsel @ 625100e2
bbb9a84
@ndiezel0 @keynslug
Fix io encoding w/ iosetopts
834d1f4
@keynslug
Bump to valitydev/damsel@dcd92dd
1f80669
@keynslug
Implement and test GetServiceProviderByID op
32d08d2
@keynslug
Drop submodules
8f7b040
@keynslug
Depend on valitydev/swag-payments@a639270
29317f9
@keynslug
Drop geo api handler and tests
452f867
@keynslug
Switch to valitydev upstream
4734fc4 
* valitydev/cowboy_access_log@04da359
* valitydev/damsel@b25d336
* valitydev/dmt-client@e9b1961
* valitydev/dmt-core@910e20e
* valitydev/party_client_erlang@8fc5595
* valitydev/woody_erlang@0c2e16d
* valitydev/woody_api_hay@4c39134
@keynslug
Drop unnecessary include
d4fea02
@keynslug
Fix testcase data
4cd74f0
@keynslug
Drop client url logging
3e4d43f
@keynslug
Setup CI/CD with GH Actions
22b7b82 
Also add Makefile conviniences and devimage setup
@keynslug
Please linter
88f67db
@codecov
Copy link

codecov bot commented Feb 4, 2022 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@8381da6). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 841747a differs from pull request most recent head efdc71e. Consider uploading reports for the commit efdc71e to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master       #1   +/-   ##
=========================================
  Coverage          ?   80.78%           
=========================================
  Files             ?       67           
  Lines             ?     4309           
  Branches          ?        0           
=========================================
  Hits              ?     3481           
  Misses            ?      828           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8381da6...efdc71e. Read the comment docs.

@keynslug keynslug requested a review from kehitt February 4, 2022 13:16
kehitt
kehitt approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@kehitt kehitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

.github/workflows/erlang-checks.yml Outdated Show resolved Hide resolved
rebar.config Show resolved Hide resolved
elvis.config Outdated Show resolved Hide resolved
elvis.config
ignore => [
capi_base_api_token_tests_SUITE, capi_idempotency_tests_SUITE
% Elvis fails with `bararg` here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется это пытались фиксить, но не до конца, видимо inaka/elvis_core#213

apps/capi/src/capi_handler_contracts.erl Outdated Show resolved Hide resolved
apps/capi/src/capi_handler_decoder_invoicing.erl Outdated Show resolved Hide resolved
apps/capi/src/capi_handler_encoder.erl Outdated Show resolved Hide resolved
@keynslug keynslug merged commit 14369d4 into master Feb 4, 2022
@keynslug keynslug deleted the TD-124/ft/ci-cd branch February 4, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kehitt kehitt kehitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keynslug @kehitt @ndiezel0