Adds blog post on Bitnami's Valkey helm chart #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
stockholmux
requested changes
Jun 27, 2024
There was a problem hiding this comment.
I really like his post!
There are a couple of small technical issues that should be easy to fix marked in the review.
The preference is to use one sentence-per-line, it makes it easier to review.
Otherwise, I'd like to see a little more distinction between Bitnami and Tanzu's app catalog: both provide value but the reader should fully know they're different and which one is open source.
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
carrodher
reviewed
Jul 1, 2024
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Rafael Ríos Saavedra <rafael.rios.saavedra@gmail.com>
Co-authored-by: Carlos Rodríguez Hernández <carlosrh@vmware.com> Signed-off-by: Rafael Ríos Saavedra <rafael.rios.saavedra@gmail.com>
|
@stockholmux Did you have the chance to take a look to my changes/comments ? |
stockholmux
requested changes
Jul 2, 2024
Signed-off-by: Rafael Rios Saavedra <rrios@vmware.com>
|
@rafariossaa I think I'm good with the post. Aim for early next week to merge and publish. |
|
Thanks ! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a blog entry about using Bitnami's Vakey helm chart.
Issues Resolved
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.