Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some dead code #129

Closed
madolson opened this issue Apr 2, 2024 · 0 comments · Fixed by #130
Closed

Cleanup some dead code #129

madolson opened this issue Apr 2, 2024 · 0 comments · Fixed by #130
Labels
good first issue Good for newcomers polish typos, style, etc

Comments

@madolson
Copy link
Member

madolson commented Apr 2, 2024 •
edited

In

valkey/src/function_lua.c

Line 357 in 0ba2f1b

sds desc = NULL;
, desc is set to NULL, never set to anything, and then checked if it should be freed on the error path if it's NUL. This can be cleaned up, since it's really unused.
@madolson madolson added good first issue Good for newcomers polish typos, style, etc labels Apr 2, 2024
@0del 0del mentioned this issue Apr 2, 2024
Merged
enjoy-binbin pushed a commit that referenced this issue Apr 2, 2024
@0del
Remove unused var desc in luaRegisterFunctionReadPositionalArgs (#130)
4d7fff9 
desc is set to NULL, never set to anything, and then
checked if it should be freed on the error path if it's NULL.
This can be cleaned up, since it's really unused.

Fixes #129

Signed-off-by: 0del <bany.y0599@gmail.com>
PatrickJS pushed a commit to PatrickJS/placeholderkv that referenced this issue Apr 24, 2024
@0del @PatrickJS
Remove unused var desc in luaRegisterFunctionReadPositionalArgs (valk…
104fdf5 
…ey-io#130)

desc is set to NULL, never set to anything, and then
checked if it should be freed on the error path if it's NULL.
This can be cleaned up, since it's really unused.

Fixes valkey-io#129

Signed-off-by: 0del <bany.y0599@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers polish typos, style, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused var desc in luaRegisterFunctionReadPositionalArgs 0del/valkey
1 participant
@madolson