Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] rebranding change needed in clocksource syscheck #352

Closed
dnwe opened this issue Apr 23, 2024 · 2 comments · Fixed by #365
Closed

[BUG] rebranding change needed in clocksource syscheck #352

dnwe opened this issue Apr 23, 2024 · 2 comments · Fixed by #365

Comments

@dnwe
Copy link

dnwe commented Apr 23, 2024

Describe the bug

The clocksource syscheck for xen still refers to redis-server in the output text rather than valkey-server:

valkey/src/syscheck.c

Lines 128 to 131 in 87a5bfc

*error_msg = sdsnew(
"Your system is configured to use the 'xen' clocksource which might lead to degraded performance. "
"Check the result of the [slow-clocksource] system check: run 'redis-server --check-system' to check if "
"the system's clocksource isn't degrading performance.");

To reproduce

Run valkey-server under the xen hypervisor with default clocksource

Expected behavior

Error message should be updated to run 'valkey-server --check-system' to check if the system's clocksource isn't degrading performance

Additional information

N/A

@enjoy-binbin
Copy link
Member

thanks, do you want to open a PR to fix this?

@hwware
Copy link
Member

hwware commented Apr 24, 2024

Thanks for reporting this bug, I already create a pr on behalf of you @dnwe
#365

enjoy-binbin pushed a commit that referenced this issue Apr 25, 2024
Fixes #352

Signed-off-by: hwware <wen.hui.ware@gmail.com>
enjoy-binbin pushed a commit that referenced this issue Apr 25, 2024
it's a supplementary modification from #352.

Signed-off-by: artikell <739609084@qq.com>
pshankinclarke pushed a commit to pshankinclarke/valkey that referenced this issue Apr 25, 2024
Fixes valkey-io#352

Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: pshankinclarke <parkerwsc1@gmail.com>
pshankinclarke pushed a commit to pshankinclarke/valkey that referenced this issue Apr 25, 2024
it's a supplementary modification from valkey-io#352.

Signed-off-by: artikell <739609084@qq.com>
Signed-off-by: pshankinclarke <parkerwsc1@gmail.com>
WM0323 pushed a commit to WM0323/valkey that referenced this issue Apr 26, 2024
Fixes valkey-io#352

Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: Sher Sun <sher.sun@huawei.com>
WM0323 pushed a commit to WM0323/valkey that referenced this issue Apr 26, 2024
it's a supplementary modification from valkey-io#352.

Signed-off-by: artikell <739609084@qq.com>
Signed-off-by: Sher Sun <sher.sun@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants