Update Valkey keyword in sentinel.conf #171
Conversation
sentinel.conf
Outdated
| @@ -145,8 +142,8 @@ sentinel down-after-milliseconds mymaster 30000 | |||
| # user worker +@admin +@connection ~* on >ffa9203c493aa99 | |||
| # | |||
| # For more information about ACL configuration please refer to the Redis | |||
| # website at https://redis.io/topics/acl and redis server configuration | |||
| # template redis.conf. | |||
| # website at https://redis.io/topics/acl and valkey server configuration | |||
There was a problem hiding this comment.
As long as our website will have the same URLs, I think this link will work. This pages are defined as files in valkey-doc.
| # website at https://redis.io/topics/acl and valkey server configuration | |
| # website at https://valkey.io/topics/acl and valkey server configuration |
There was a problem hiding this comment.
Address your comments, and I update redis.io to valkey.io in 2 places, pls take a look. Thanks
hwware
force-pushed
the
update-sentinel-keyword
branch
from
22d7a3a
to
dc52cd8
Compare
| # When running daemonized, Redis Sentinel writes a pid file in | ||
| # /var/run/redis-sentinel.pid by default. You can specify a custom pid file | ||
| # When running daemonized, Valkey Sentinel writes a pid file in | ||
| # /var/run/valkey-sentinel.pid by default. You can specify a custom pid file | ||
| # location here. | ||
| pidfile /var/run/redis-sentinel.pid | ||
| pidfile /var/run/valkey-sentinel.pid |
There was a problem hiding this comment.
It seems like this is the default pidfile only if this config file is used. If sentinel is started without this config, the default is this one in server.c:
#define CONFIG_DEFAULT_PID_FILE "/var/run/redis.pid"
If this is true, then at least it's not a new issue, so we don't have to change it today. It would just be interesting to know if this is true.
There was a problem hiding this comment.
yes, you are right. It works like this:
if (background || server.pidfile) createPidFile(); (server.c)
Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: hwware <wen.hui.ware@gmail.com>
Signed-off-by: hwware <wen.hui.ware@gmail.com>
hwware
force-pushed
the
update-sentinel-keyword
branch
from
f6e1e11
to
ad7b9e7
Compare
|
@valkey-io/core-team Include this in the 7.2.x release? |
any reason not include in 7.2 release? |
Mostly comments, but one pre-filled config in this template config file
is changed:
pidfile /var/run/valkey-sentinel.pid
---------
Signed-off-by: hwware <wen.hui.ware@gmail.com>
Mostly comments, but one pre-filled config in this template config file
is changed:
pidfile /var/run/valkey-sentinel.pid
---------
Signed-off-by: hwware <wen.hui.ware@gmail.com>
Mostly comments, but one pre-filled config in this template config file is changed: