Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0del
force-pushed
the
remove/ValkeyModuleEvent_MasterLinkChange
branch
from
55a33d4
to
489bbcf
Compare
madolson
reviewed
Apr 8, 2024
…LinkChange Signed-off-by: 0del <bany.y0599@gmail.com>
0del
force-pushed
the
remove/ValkeyModuleEvent_MasterLinkChange
branch
from
934c902
to
db0633d
Compare
madolson
changed the title
madolson
approved these changes
Apr 8, 2024
madolson
pushed a commit
to madolson/valkey
that referenced
this pull request
Apr 8, 2024
…yLinkChange (valkey-io#262) Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange Signed-off-by: 0del <bany.y0599@gmail.com>
|
I think the Redis event name needs to be reverted back to Master to maintain source compat. Changing
|
|
Yes, let's fix this for RC2. We'll see if anyone comments about it. |
PatrickJS
pushed a commit
to PatrickJS/placeholderkv
that referenced
this pull request
Apr 24, 2024
…yLinkChange (valkey-io#262) Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange Signed-off-by: 0del <bany.y0599@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #249