Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update REDIS* to VALKEY* in object.c and utils/create-cluster/README #380

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

WM0323
Copy link
Contributor

@WM0323 WM0323 commented Apr 25, 2024

  1. Rename REDIS_* macros defined in object.c to VALKEY_*,
  2. Rename Redis to Valkey , redis-cli to valkey-cli in logs (i.e. put statement) and descriptions in object.c and utils/create-cluster/README

Sher Sun added 2 commits April 25, 2024 17:59
Signed-off-by: Sher Sun <sher.sun@huawei.com>
fix
Signed-off-by: Sher Sun <sher.sun@huawei.com>
src/object.c Outdated Show resolved Hide resolved
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion in object.c, looks good otherwise.

Signed-off-by: Sher Sun <sher.sun@huawei.com>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 68.39%. Comparing base (4948d53) to head (21f3329).
Report is 4 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #380      +/-   ##
============================================
+ Coverage     68.37%   68.39%   +0.01%     
============================================
  Files           108      108              
  Lines         61562    61563       +1     
============================================
+ Hits          42096    42103       +7     
+ Misses        19466    19460       -6     
Files Coverage Δ
src/object.c 78.41% <37.50%> (+0.43%) ⬆️

... and 10 files with indirect coverage changes

@WM0323 WM0323 requested a review from madolson April 26, 2024 16:25
@madolson madolson merged commit a5a1377 into valkey-io:unstable Apr 26, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants