Migrate kvstore.c unit tests to new test framework. #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #446 +/- ##
=========================================
Coverage 68.91% 68.92%
=========================================
Files 109 109
Lines 61793 61793
=========================================
+ Hits 42587 42591 +4
+ Misses 19206 19202 -4
|
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
|
Thank you for doing this incrementally :) |
madolson
reviewed
May 7, 2024
| @@ -0,0 +1,206 @@ | |||
|
|
|||
| #include "../kvstore.c" | |||
| #undef UNUSED | |||
There was a problem hiding this comment.
Given the rest of this looks good, you could maybe add this to another PR. Maybe we can update the definition in test_help to be:
#ifndef UNUSED
#define UNUSED(x) (void)(x)
#endif
To avoid all of this repetition.
There was a problem hiding this comment.
@madolson sure, I will create a separate PR to address this repetition issue.
madolson
reviewed
May 7, 2024
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
madolson
approved these changes
May 7, 2024
madolson
pushed a commit
that referenced
this pull request
May 9, 2024
This is a follow-up PR to address UNUSED repetition issue (see #446 (comment)) in different test source files. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
12 tasks
karthyuom
added a commit
to karthyuom/valkey
that referenced
this pull request
May 13, 2024
This PR migrates all tests related to kvstore into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
karthyuom
added a commit
to karthyuom/valkey
that referenced
this pull request
May 13, 2024
This is a follow-up PR to address UNUSED repetition issue (see valkey-io#446 (comment)) in different test source files. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
srgsanky
pushed a commit
to srgsanky/valkey
that referenced
this pull request
May 19, 2024
This is a follow-up PR to address UNUSED repetition issue (see valkey-io#446 (comment)) in different test source files. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all tests related to kvstore into new test framework as part of the parent issue #428.