Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Support fast fail option for tcl test cases #452

Closed
wants to merge 0 commits into from

Conversation

arthurkiller
Copy link
Contributor

Hi, new here in valkey community.

This PR added a new option for tcl test case which will fail fast once any test cases fail.
This can be useful while running redis CI pipeline, and you want to accelerate the CI pipeline.

Appreciate all the things you guys have done, hope can contribute to this project.

@arthurkiller
Copy link
Contributor Author

usage for example

./runtest --single unit/type/hash --fastfail

[ok]: HSET/HLEN - Small hash creation (2 ms)
[ok]: Is the small hash encoded with a listpack? (0 ms)
[ok]: HRANDFIELD - listpack (8 ms)
[ok]: HRANDFIELD - hashtable (7 ms)
Test error (last server port:21113, log:./tests/tmp/server.3935664.1/stdout), test will exit now
[err]: HRANDFIELD with RESP3 in tests/unit/type/hash.tcl
Expected '3' to be equal to '2333' (context: type eval line 8 cmd {assert_equal [llength $res] 2333} proc ::test)
(Fastfail: test will exit now)

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.92%. Comparing base (ba9dd7b) to head (20239f9).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #452      +/-   ##
============================================
- Coverage     68.95%   68.92%   -0.03%     
============================================
  Files           109      109              
  Lines         61793    61793              
============================================
- Hits          42611    42593      -18     
- Misses        19182    19200      +18     

see 13 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant