Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make cluster meet reliable under link failures #461

Merged
merged 11 commits into from
Jun 17, 2024
Merged

Make cluster meet reliable under link failures #461

merged 11 commits into from
Jun 17, 2024

Commits on May 20, 2024

  1. Make cluster meet reliable under link failures 

    When there is a link failure while an ongoing MEET request is sent the
sending node stops sending anymore MEET and starts sending PINGs. Since
every node responds to PINGs from unknown nodes with a PONG, the
receiving node never adds the sending node. But the sending node adds
the receiving node when it sees a PONG. This can lead to asymmetry in
cluster membership. This changes makes the sender keep sending MEET
until it sees a PONG, avoiding the asymmetry.

Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 20, 2024
    Configuration menu
    Copy the full SHA
    49e5a7f View commit details
    Browse the repository at this point in the history

  2. Merge commit 'd52c8f30e' into unstable 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d8e6da5 View commit details
    Browse the repository at this point in the history

  3. Moved test under unit and addressed other comments 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 20, 2024
    Configuration menu
    Copy the full SHA
    ec68829 View commit details
    Browse the repository at this point in the history

  4. Addressed comments about the unit test 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 20, 2024
    Configuration menu
    Copy the full SHA
    a760aa6 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Addressed comments 

    1. Reworked code comment
1. Added serverLogs
1. Renamed debug variable
1. Made close link filter to be directly coupled with drop filter

Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0cf724a View commit details
    Browse the repository at this point in the history

Commits on May 29, 2024

  1. Added test case for multiple MEETs 

    Multiple MEETs will be handled like a normal PING message.

Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 29, 2024
    Configuration menu
    Copy the full SHA
    1abf81c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/unstable' into unstable 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 29, 2024
    Configuration menu
    Copy the full SHA
    da01bb8 View commit details
    Browse the repository at this point in the history

  3. Resolved the merge conflict missed in previous commit 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 29, 2024
    Configuration menu
    Copy the full SHA
    be5cb97 View commit details
    Browse the repository at this point in the history

  4. Fixed clang-format errors 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 29, 2024
    Configuration menu
    Copy the full SHA
    d6b9cbd View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/unstable' into unstable 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 29, 2024
    Configuration menu
    Copy the full SHA
    50f896b View commit details
    Browse the repository at this point in the history

  6. Fixed format to keep type and field in same line 

    Signed-off-by: Sankar <1890648+srgsanky@users.noreply.github.com>
    @srgsanky
    srgsanky committed May 29, 2024
    Configuration menu
    Copy the full SHA
    7ac84b6 View commit details
    Browse the repository at this point in the history