Support RDB compatability with Redis 7.2.4 RDB format #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes our current RDB format compatible with the Redis 7.2.4 RDB format. there are 2 changes introduced in this PR: 1. Move back the RDB version to 11 2. Make slot info section persist as AUX data instead of dedicated section. We have introduced slot-info as part of the work to replace cluster metadata with slot specific dictionaries. This caused us to bump the RDB version and thus we prevent downgrade (which is conceptualy O.K but better be prevented). We do not require the slot-info section to exist, so making it an AUX section will help suppport version downgrade from Valkey 8. fixes: [valkey-io#645](valkey-io#645) Signed-off-by: ranshid <ranshid@amazon.com>
Signed-off-by: ranshid <ranshid@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #665 +/- ##
============================================
- Coverage 70.20% 69.99% -0.21%
============================================
Files 110 110
Lines 60078 60069 -9
============================================
- Hits 42179 42047 -132
- Misses 17899 18022 +123
|
Signed-off-by: ranshid <ranshid@amazon.com>
zuiderkwast
approved these changes
Jun 18, 2024
madolson
added
the
release-notes
Co-authored-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: ranshid <ranshid@amazon.com>
ranshid
force-pushed
the
fix-rdb-compatibility-issues
branch
from
c678783
to
b8089a1
Compare
hpatro
approved these changes
Jun 18, 2024
madolson
approved these changes
Jun 18, 2024
|
Added release notes tag to remind us that we need to make it clear that we don't want to indicate that is an RDB op code bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our current RDB format compatible with the Redis 7.2.4 RDB format. there are 2 changes introduced in this PR:
We have introduced slot-info as part of the work to replace cluster metadata with slot specific dictionaries. This caused us to bump the RDB version and thus we prevent downgrade (which is conceptualy O.K but better be prevented). We do not require the slot-info section to exist, so making it an AUX section will help suppport version downgrade from Valkey 8.
fixes: #645
NOTE: tested manually by: