Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rest package #121

Merged
merged 5 commits into from
Mar 21, 2023
Merged

Rest package #121

merged 5 commits into from
Mar 21, 2023

Conversation

gustavste
Copy link
Contributor

  • Single HttpClient, caller decides how to parse/write the response/request
    • package provides some common parsers
  • rename rest -> valkhttp

@gustavste gustavste requested a review from gnirb March 21, 2023 09:34
@github-actions
Copy link

Previous Coverage 63.6% of statements
New Coverage 64.0% of statements
Patch Coverage 86.8% of changed statements (118/136)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

gnirb
gnirb approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@gnirb gnirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice improvement to the api

@gustavste gustavste merged commit eebcebd into main Mar 21, 2023
@gustavste gustavste deleted the Rest_package branch March 21, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnirb gnirb gnirb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gustavste @gnirb