chore(npm): update publish logic

valkyrjs · Feb 20, 2023 · 243df3e · 243df3e
1 parent ec09bb9
commit 243df3e
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 13 deletions.
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -10,15 +10,15 @@ jobs:
     runs-on: ubuntu-latest
     environment: NPM Release Publishing
     steps:
-      - uses: actions/checkout@2541b1294d2704b0964813337f33b291d3f8596b
+      - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c
 
-      - uses: pnpm/action-setup@10693b3829bf86eb2572aef5f3571dcf5ca9287d
+      - uses: pnpm/action-setup@c3b53f6a16e57305370b4ae5a540c2077a1d50dd
         with:
           version: 7
 
-      - uses: actions/setup-node@2fddd8803e2f5c9604345a0b591c3020ee971a93
+      - uses: actions/setup-node@64ed1c7eab4cce3362f8c340dee64e5eaeef8f7c
         with:
-          node-version: 16
+          node-version-file: ".nvmrc"
           cache: pnpm
 
       - uses: actions/github-script@e3cbab99d3a9b271e1b79fc96d103a4a5534998c

diff --git a/scripts/version.js b/scripts/version.js
@@ -12,21 +12,27 @@ for (const pkg of pkgs) {
 
   json.version = version;
 
-  for (const key of json.dependencies) {
-    if (json.dependencies[key].includes("workspace:*")) {
-      json.dependencies[key] = version;
+  if (json.dependencies !== undefined) {
+    for (const key in json.dependencies) {
+      if (json.dependencies[key].includes("workspace:*")) {
+        json.dependencies[key] = version;
+      }
     }
   }
 
-  for (const key of json.devDependencies) {
-    if (json.devDependencies[key].includes("workspace:*")) {
-      json.devDependencies[key] = version;
+  if (json.devDependencies !== undefined) {
+    for (const key in json.devDependencies) {
+      if (json.devDependencies[key].includes("workspace:*")) {
+        json.devDependencies[key] = version;
+      }
     }
   }
 
-  for (const key of json.peerDependencies) {
-    if (json.peerDependencies[key].includes("workspace:*")) {
-      json.peerDependencies[key] = version;
+  if (json.peerDependencies !== undefined) {
+    for (const key in json.peerDependencies) {
+      if (json.peerDependencies[key].includes("workspace:*")) {
+        json.peerDependencies[key] = version;
+      }
     }
   }