Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups #3

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Various cleanups #3

merged 11 commits into from
Nov 6, 2023

Conversation

akx
Copy link
Member

@akx akx commented Nov 2, 2023

This PR:

  • cleans up requirements (could still clean up more; e.g. inference shouldn't require all of the things training does)
  • fixes some minor bugs (e.g. leaky globals, this and that)
  • makes the project work even without bitsandbytes
  • deduplicates some code

@akx akx requested review from SofiaChar, a team, ruksi and tokkoro and removed request for a team November 2, 2023 10:16
@akx akx marked this pull request as ready for review November 2, 2023 10:16
@akx
Copy link
Member Author

akx commented Nov 2, 2023

NB: I haven't run this branch on Valohai yet (I don't have access to the project/datasets/S3 bucket currently used), so if someone wants to give that a shot...

Copy link
Contributor

@tokkoro tokkoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are clean and clear.

Was not able to properly run executions as I don't have access to the data store.

Copy link
Collaborator

@SofiaChar SofiaChar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

@tokkoro
Copy link
Contributor

tokkoro commented Nov 6, 2023

@akx can you rebase so it can be merged? :)

@akx
Copy link
Member Author

akx commented Nov 6, 2023

@tokkoro Done. Rebasing took a while since I had to untangle some of the duplicate work done in a4b5451.

@tokkoro tokkoro merged commit 52154a8 into main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants