Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_ulid_time in early Python 2.7 versions #3

Merged
merged 1 commit into from Mar 8, 2017
Merged

Fix get_ulid_time in early Python 2.7 versions #3

merged 1 commit into from Mar 8, 2017

Conversation

larsyencken
Copy link
Contributor

Adds the b'' string prefix, since unicode struct specifications weren't supported in early minor releases of Python 2.7.

In Python 2.7.6 the unit test was failing for get_ulid_time(). Now they pass again. I also confirmed that they continue to pass for 2.7.13 and 3.6.0.

Adds the b'' string prefix, since unicode struct specifications weren't
supported in early minor releases of Python 2.7.
@larsyencken
Copy link
Contributor Author

Fixes #2

@codecov-io
Copy link

codecov-io commented Mar 8, 2017

Codecov Report

Merging #3 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master      #3   +/-   ##
======================================
  Coverage    97.7%   97.7%           
======================================
  Files           2       2           
  Lines          87      87           
======================================
  Hits           85      85           
  Misses          2       2
Impacted Files Coverage Δ
ulid2.py 96.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e60168...a85d263. Read the comment docs.

@akx akx merged commit 63d4906 into valohai:master Mar 8, 2017
@akx
Copy link
Member

akx commented Mar 8, 2017

Thanks a lot, @larsyencken! Released in ulid2 0.1.1.

akx added a commit that referenced this pull request Sep 22, 2021
akx added a commit that referenced this pull request Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants