relax peer dependency to support angular 4.0.0

[Ketec]

currently it results in "requires a peer of" warnings.
It works on current angular 4 release, so perhaps the peerDep could be relaxed to >=4.0.0?

[Drol]

On 1.3.1 i get the following errors

warning "ng2-dragula@1.3.1" has incorrect peer dependency "@angular/compiler@2.4.3".
warning "ng2-dragula@1.3.1" has incorrect peer dependency "@angular/forms@2.4.3".

Packages

  "dependencies": {
    "@angular/common": "4.0.1",
    "@angular/compiler": "4.0.1",
    "@angular/core": "4.0.1",
    "@angular/forms": "4.0.1",
    "@angular/http": "4.0.1",
    "@angular/platform-browser": "4.0.1",
    "@angular/platform-browser-dynamic": "4.0.1",
    "core-js": "2.4.1",
    "ng2-dragula": "1.3.1",
    "rxjs": "5.3.0",
    "zone.js": "0.8.5"
  },
  "devDependencies": {
    "@angular/compiler-cli": "4.0.1",
    "@types/node": "7.0.12",
    "angular2-template-loader": "0.6.2",
    "awesome-typescript-loader": "3.1.2",
    "raw-loader": "0.5.1",
    "ts-loader": "2.0.3",
    "ts-node": "3.0.2",
    "tslint": "^5.1.0",
    "typescript": "2.2.2",
    "webpack": "2.3.3",
    "webpack-notifier": "1.5.0",
    "xml-loader": "1.2.1"
  }

[peterlaraia]

Seeing the same as @Drol, look like maybe ngm is picking up & merging the peer dependencies in src/package.json in the build step?

[fredpolicarpo]

I'm also having the same problem as @Drol

npm WARN ng2-dragula@1.3.1 requires a peer of @angular/compiler@2.4.3 but none was installed.
npm WARN ng2-dragula@1.3.1 requires a peer of @angular/forms@2.4.3 but none was installed.

[lawmbass]

Same here. Is there a current work around to getting rid of these warnings?

[fluky]

+1, please get rid of fixed versions as well:

"@angular/compiler": ">=2.0.0 || >=4.0.0-beta.0"

[Hesesses]

+1

[basst314]

+1

[NeuralChris]

+1

[vaidd4]

In the ng2-dragula github sources, @angular/compiler & @angular/forms are mentionned as devDependencies, but when pulled from npm they are added to peerDependencies.
Any reason why ?

[peterlaraia]

@vaidd4 I'm pretty sure it's because the build tool being used, ngm-cli, is merging this package.json from the src folder, and using the versions it finds in the root package.json's devDependencies.

So I figure either the peerDependencies versions of compiler & forms need to be explicitly set in the root package.json, like core & common, or they need to be removed from the src/package.json. I haven't made a PR because I'm not sure which is more appropriate

[malecki-se]

+1

[BogalooDev]

+1

[rphovley]

+1

[gabrielrosset]

+1

[BogalooDev]

Committed fix regarding @angular/compiler & @angular/forms fixed version and migrated Karma to @Angular/CLI approach in order to fix failing test run based on this

[vaidd4]

thanks for the comment @BogalooDev !
Is the fix available in the v1.3.1 ?
If not, will it be available in next version ?
If so, why did you close the issue if the fix isn't published yet ?

[cormacrelf]

Chill out, this fix is literally just two lines of warnings no longer appearing when you do a build. Will be the only thing in 1.3.2 when that's released, I'm not in charge of that though. Shouldn't have closed in the commit message, I meant to just close the PRs.

[vaidd4]

Oh It wasn't meant to be an aggressive comment, I was just covering the possible answers ^^
Sorry and thanks for your answer

[emin93]

Actually this causes more than just a warning if you work with NPM Shrinkwrap. When you try to create a shrinkwrap, it will fail with the following errors.

npm shrinkwrap
npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! peer invalid: @angular/compiler@2.4.3, required by ng2-dragula@1.3.1
npm ERR! peer invalid: @angular/forms@2.4.3, required by ng2-dragula@1.3.1

[cormacrelf]

Folks at valor-software are in charge of releasing. I asked about a week ago, got a reply but no action yet.

[fluky]

Somebody needs to fork this, it meets all the criteria of dead software. When you can't even get a 3 character change done in 2 months...

[cormacrelf]

@fluky Yeah look, you're probably right. Plus there's lots of stuff we just can't do without a bit of rewriting, see #728. Ideally we should be able to do most stuff react-dnd can do.

[axtho]

If valor is not actively maintaining this I too am all for forking. It is a great library and it would be a pity if it stalls. There are not many good dnd libs for Angular4 out there. What would be in improvement on react-dnd would be to enable proper touch enabled drag/drop/sort (AFAIK dragula does that to some degree).

[OliverNeff]

It is fixed on master branch. How can I include it in npm directly from github?

[aeimer]

psss... A new release is comming soon ;)

[aeimer]

Since the version 1.5.0 is out we can close this issue?! @Ketec

[valorkin]

published

[stewx]

Where is 1.5.0? It's not in the list of releases: https://github.com/valor-software/ng2-dragula/releases

[vaidd4]

@stewx FYI, I made an issue on this here : #747