Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): should work within onPush components #2038

Merged
merged 1 commit into from Jun 15, 2017
Merged

fix(button): should work within onPush components #2038

merged 1 commit into from Jun 15, 2017

Conversation

artemvfrolov
Copy link
Contributor

issue #1689

@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #2038 into development will increase coverage by 0.01%.
The diff coverage is 96.87%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2038      +/-   ##
===============================================
+ Coverage        87.16%   87.17%   +0.01%     
===============================================
  Files               85       85              
  Lines             2259     2261       +2     
  Branches           292      292              
===============================================
+ Hits              1969     1971       +2     
  Misses             187      187              
  Partials           103      103
Impacted Files Coverage Δ
src/buttons/button-radio.directive.ts 97.29% <96.87%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c172423...f9d7a93. Read the comment docs.

@valorkin
Copy link
Member

@YevheniiaMazur please test

@YevheniiaMazur
Copy link

YevheniiaMazur commented Jun 12, 2017

Tested. Issue #1689 is fixed. Changes in the status of the button are viewed correctly

@valorkin valorkin changed the title Fix button with on push fix(button): should work within onPush components Jun 15, 2017
@valorkin valorkin merged commit aec0f86 into valor-software:development Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants