Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): add POC for use-cases - accordion example #4677

Merged
merged 1 commit into from Oct 17, 2018
Merged

feat(docs): add POC for use-cases - accordion example #4677

merged 1 commit into from Oct 17, 2018

Conversation

ludmilanesvitiy
Copy link
Contributor

@ludmilanesvitiy ludmilanesvitiy commented Oct 9, 2018 •
edited

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ludmilanesvitiy ludmilanesvitiy self-assigned this Oct 9, 2018
@ghost ghost removed the in progress label Oct 9, 2018
@codecov
Copy link

codecov bot commented Oct 9, 2018 •
edited

Codecov Report

Merging #4677 into development will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4677      +/-   ##
===============================================
- Coverage        74.35%   74.32%   -0.03%     
===============================================
  Files              202      202              
  Lines             7101     7101              
  Branches          1446     1446              
===============================================
- Hits              5280     5278       -2     
- Misses            1425     1427       +2     
  Partials           396      396
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 72.22% <0%> (-2.78%) ⬇️
src/chronos/i18n/sk.ts 80.85% <0%> (-2.13%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (-1.7%) ⬇️
src/chronos/i18n/uk.ts 80.48% <0%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eeab60...c78fb5c. Read the comment docs.

@ludmilanesvitiy ludmilanesvitiy force-pushed the feat-docs-use-cases-poc branch 12 times, most recently from 4dce941 to 353d842 Compare October 10, 2018 06:59
@ludmilanesvitiy ludmilanesvitiy force-pushed the feat-docs-use-cases-poc branch 2 times, most recently from 95ec7f4 to 87b807a Compare October 10, 2018 09:59
OlegDubrovskyi
OlegDubrovskyi reviewed Oct 10, 2018
View reviewed changes
docs/spec/accordion/accordion.examples.group-open.use-case.md Outdated
Variations:
-----------
2*. User scroll to Group opening event sub-menu

This comment was marked as off-topic.

Sign in to view

@ghost ghost added the needs review label Oct 10, 2018
OlegDubrovskyi
OlegDubrovskyi previously approved these changes Oct 10, 2018
View reviewed changes
valorkin
valorkin requested changes Oct 11, 2018
View reviewed changes
Copy link
Member

@valorkin valorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for other versions
When and how svgs are rendered?

docs/spec/accordion/accordion.examples.basic.use-case.md Outdated
============================
**Primary Actor**: User

**Scope**: Ngx-bootstrap DEMO / BS version 4/ v.3.0.1

This comment was marked as off-topic.

Sign in to view

@ludmilanesvitiy
Copy link
Contributor Author

fixed versions for all files
svg generated in online editor https://mermaidjs.github.io/mermaid-live-editor/#/edit/eyJjb2RlIjoiZ3JhcGggVERcbkFbQ2hyaXN0bWFzXSAtLT58R2V0IG1vbmV5fCBCKEdvIHNob3BwaW5nKVxuQiAtLT4gQ3tMZXQgbWUgdGhpbmt9XG5DIC0tPnxPbmV8IERbTGFwdG9wXVxuQyAtLT58VHdvfCBFW2lQaG9uZV1cbkMgLS0-fFRocmVlfCBGW2ZhOmZhLWNhciBDYXJdXG4iLCJtZXJtYWlkIjp7InRoZW1lIjoiZGVmYXVsdCJ9fQ
But besides use-case, for generating svg we need to support Mermaid configuration, it's a double work. That's why I don't recommend using it now. This is just example how it could looks like

valorkin
valorkin previously approved these changes Oct 12, 2018
View reviewed changes
valorkin
valorkin previously approved these changes Oct 17, 2018
View reviewed changes
@valorkin valorkin merged commit 4d3e342 into development Oct 17, 2018
@delete-merged-branch delete-merged-branch bot deleted the feat-docs-use-cases-poc branch October 17, 2018 10:51
@ghost ghost removed the ready for merge label Oct 17, 2018
svetoldo4444ka pushed a commit to svetoldo4444ka/ngx-bootstrap that referenced this pull request Nov 6, 2018
@ludmilanesvitiy @svetoldo4444ka
feat(docs): add use-cases for accordion component (valor-software#4677)
212a0d1
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
@ludmilanesvitiy @leo6104
feat(docs): add use-cases for accordion component (valor-software#4677)
35ea949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valorkin valorkin valorkin approved these changes

@OlegDubrovskyi OlegDubrovskyi OlegDubrovskyi left review comments

@Domainv Domainv Awaiting requested review from Domainv

Assignees

@ludmilanesvitiy ludmilanesvitiy

Labels
comp(accordion) enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludmilanesvitiy @valorkin @OlegDubrovskyi