Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): add z-index for dropdown to not be overrided by modal #5627

Merged
merged 1 commit into from Jan 31, 2020

Conversation

daniloff200
Copy link
Contributor

PR Checklist

closes #5144

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #5627 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #5627   +/-   ##
============================================
  Coverage        52.52%   52.52%           
============================================
  Files                3        3           
  Lines               99       99           
  Branches            17       17           
============================================
  Hits                52       52           
  Misses              37       37           
  Partials            10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d626faf...dcb9ad3. Read the comment docs.

@daniloff200 daniloff200 changed the title fix(dropdown): add z-inded for dropdown to not be overrided by modal fix(dropdown): add z-index for dropdown to not be overrided by modal Jan 29, 2020
@nigelsim
Copy link
Contributor

I'm not sure 1040 is the correct value. From BS3 _variables.scss file the modal is at 1050.

$zindex-modal-background:  1040 !default;
$zindex-modal:             1050 !default;

Following this patch all of our dropdowns that are in modals started being put behind, where previously we had adjusted their z-index with CSS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown in modal issue
4 participants