Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore ci): change sourceRoot to deepen ng cli run scope, add ampe… #5674

Merged
merged 6 commits into from Feb 20, 2020
Merged

fix(chore ci): change sourceRoot to deepen ng cli run scope, add ampe… #5674

merged 6 commits into from Feb 20, 2020

Conversation

belinef
Copy link
Contributor

@belinef belinef commented Feb 18, 2020

fix(chore ci): change sourceRoot to deepen ng cli run scope, add ampersands to prevent multiple scopes in script run.

…rsands to prevent multiple scopes in script run.
IraErshova
IraErshova previously approved these changes Feb 18, 2020
daniloff200
daniloff200 previously approved these changes Feb 18, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #5674 into development will increase coverage by 0.03%.
The diff coverage is 84.21%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #5674      +/-   ##
===============================================
+ Coverage        73.52%   73.55%   +0.03%     
===============================================
  Files              321      321              
  Lines            11538    11538              
  Branches          2457     2457              
===============================================
+ Hits              8483     8487       +4     
+ Misses            1968     1964       -4     
  Partials          1087     1087
Impacted Files Coverage Δ
.../datepicker/bs-daterangepicker-inline.component.ts 41.09% <ø> (ø) ⬆️
src/datepicker/base/bs-datepicker-container.ts 75% <ø> (ø) ⬆️
src/datepicker/bs-datepicker.config.ts 85.18% <ø> (ø) ⬆️
src/datepicker/bs-daterangepicker.component.ts 75.43% <100%> (ø) ⬆️
...hemes/bs/bs-daterangepicker-container.component.ts 70.96% <80%> (ø) ⬆️
...picker/themes/bs/bs-custom-dates-view.component.ts 69.56% <84.61%> (ø) ⬆️
src/datepicker/bs-datepicker.component.ts 66.07% <0%> (-1.79%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3d0432...15b669d. Read the comment docs.

@daniloff200
Copy link
Contributor

@dmitry-zhemchugov for unknown reason, both Smoke tests jobs are failed
could you check that please?

@IraErshova
Copy link
Contributor

@dmitry-zhemchugov for unknown reason, both Smoke tests jobs are failed
could you check that please?

@belinef thought that it could be because of his changes. Need more investigation

…sts to prevent Errors while no tests in test-run.
@belinef belinef dismissed stale reviews from daniloff200 and IraErshova via 7d36697 February 20, 2020 10:30
IraErshova
IraErshova previously approved these changes Feb 20, 2020
Copy link
Contributor

@IraErshova IraErshova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me, but I have doubts regarding this moment
http://dl3.joxi.net/drive/2020/02/20/0023/0818/1569586/86/a6974f8520.png
@belinef Could you please approve that this code is correct?

@belinef
Copy link
Contributor Author

belinef commented Feb 20, 2020

Everything looks good to me, but I have doubts regarding this moment
http://dl3.joxi.net/drive/2020/02/20/0023/0818/1569586/86/a6974f8520.png
@belinef Could you please approve that this code is correct?

@IraErshova in case for styles and polyfills there is no restrictions in path. There only restriction in assets which path should be started from project sourceRoot.

@belinef belinef requested review from daniloff200 and IraErshova and removed request for valorkin February 20, 2020 13:20
@daniloff200 daniloff200 merged commit 198cdf1 into valor-software:development Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants