Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal: closeinterceptor not working on versions from 10.0.0 to 11.0.2 #6608

Open
amoroso81 opened this issue Sep 14, 2023 · 2 comments
Open

Modal: closeinterceptor not working on versions from 10.0.0 to 11.0.2 #6608

amoroso81 opened this issue Sep 14, 2023 · 2 comments
Assignees
@lexasq
Labels
comp(modal)

Comments

@amoroso81
Copy link

amoroso81 commented Sep 14, 2023 •
edited
Loading

Bug description:
The closeinterceptor function related to modal dialogs is not being called using version 11.0.2. An example could be found on your demo page at the section Close interceptor: clicking the Close button should open a new confirm dialog, but that does not appear and the previous modal dialog gets closed; choosing version 9.0.0 the confim dialog appears and everything works.

Versions of ngx-bootstrap, Angular, and Bootstrap:

ngx-bootstrap:
11
Angular:
16
Bootstrap:
5
@amoroso81
Copy link
Author

I did some debug about this problem and found that it was introduced in version 10.0.0 by this commit ( 8f0807e ). Now it seems that none calls the method modalContainerRef.instance?.hide() which is deputed to call the closeInterceptor method. Could someone please look further at this bug and provide a fix? Thanks in advance.

@amoroso81 amoroso81 changed the title Modal: closeinterceptor not working on version 11.0.2 Modal: closeinterceptor not working on versions from 10.0.0 to 11.0.2 Sep 25, 2023
@rgbweb rgbweb mentioned this issue Mar 22, 2024
Open
renaldas-kerpe-arria referenced this issue May 15, 2024
@alejandrocoding @valorkin
fix(modal): hide works even if show hasn't finished (#6518)
8f0807e 
* fix(modal): hide works even if show hasn't finished

* (test:modal): bring back done & tests isolation

Co-authored-by: Dmitriy Shekhovtsov <valorkin@gmail.com>
@renaldas-kerpe-arria
Copy link

Is anyone looking into this? We have just finished updating to Angular 17 and all the third libraries and it would be a massive pain if we had to downgrade... This is causing several bugs in our app.

Merged
5 tasks
@lexasq lexasq self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexasq lexasq

Labels
comp(modal)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amoroso81 @lexasq @renaldas-kerpe-arria