Skip to content

Commit

Permalink
fix(analytics): invoke ValoraAnalytics.init correctly (#3823)
Browse files Browse the repository at this point in the history
### Description

`this` object was not bound correctly causing analytics events to not
fire since #3672 which went in
on 1.57.0

### Test plan

Manually, by enabling analytics on dev build

Before, ValoraAnalytics.track was bailing here
https://github.com/valora-inc/wallet/blob/ffb97d37a158a78b61dd4a507b3d7dad5b168fa5/src/analytics/ValoraAnalytics.ts#L249-L252

After the fix, confirmed with logs that events are successfully sent to
segment

### Related issues

N/A

### Backwards compatibility

N/A
  • Loading branch information
satish-ravi committed Jun 1, 2023
1 parent ffb97d3 commit bcaec7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/app/saga.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export function* appInit() {

yield all([
call(initializeSentry),
call(ValoraAnalytics.init),
call([ValoraAnalytics, 'init']),
call(
initI18n,
language || bestLanguage || DEFAULT_APP_LANGUAGE,
Expand Down

0 comments on commit bcaec7f

Please sign in to comment.