Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade lottie #3441

Merged
merged 1 commit into from
Feb 10, 2023
Merged

chore: upgrade lottie #3441

merged 1 commit into from
Feb 10, 2023

Conversation

kathaypacific
Copy link
Collaborator

Description

The latest version of lottie-react-native no longer requires us to directly depend on lottie-ios :D

Test plan

Tested the loading spinner animation on ios and android manually to see that lottie still works on both platforms.

Related issues

Backwards compatibility

Y

@emerge-tools
Copy link

emerge-tools bot commented Feb 10, 2023

📏 Size Analysis

Total install size 60.2 MB | This change: ⬆️ +694.9 kB (+1.17%)

Image of diff

🗂 See size breakdown
Item Install size
Lottie.framework/Lottie 🔺 447.7 kB
Lottie.framework/Code Signature 🔺 39.2 kB
Lottie.framework/DYLD.Exports 🔺 9.5 kB
Lottie.framework/Strings.Unmapped 🔺 5.0 kB
➕ Lottie.framework/Swift._ArrayBufferProtocol.replaceSubrange(with,elementsOf) 🔺 2.8 kB
➕ lottie_react_native.framework/lottie_react_native.ContainerView.setSourceURL 🔺 2.8 kB
Lottie.framework/Lottie.framework/Lottie 🔺 2.7 kB
Lottie.framework/DYLD.Lazy Bind 🔺 2.7 kB
Lottie.framework/DYLD.Bind 🔺 2.6 kB
Lottie.framework/Swift._NativeDictionary._copyOrMoveAndResize(capacity,moveElements) 🔺 1.7 kB
lottie_react_native.framework/DYLD.Lazy Bind 🔺 1.7 kB
➕ Lottie.framework/CoreGraphics.UnsafeMutableBufferPointer._stableSortImpl(by) 🔺 1.7 kB
➕ lottie_react_native.framework/lottie_react_native.ContainerView.setTextFiltersIOS 🔺 1.4 kB
➕ Lottie.framework/CoreTextRenderLayer.Objc Metadata 🔺 1.4 kB
➖ Lottie.framework/AnimationContainer ⬇️ 1.3 kB
➕ Lottie.framework/CoreAnimationLayer.Objc Metadata 🔺 1.2 kB
➕ Lottie.framework/__C.CALayer.keyframeAnimation(for,keyframes,value,customKeyTimes,context) 🔺 1.2 kB
➕ Lottie.framework/__C._arrayForceCast 🔺 1.2 kB
➕ Lottie.framework/__C.Array.Array 983 B
➕ lottie_react_native.framework/Swift._NativeDictionary._copyOrMoveAndResize(capacity,moveElements) 980 B

🔎 See the full size analysis (343f66f) merging into main (4e35a5f)

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #3441 (343f66f) into main (4e35a5f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   81.08%   81.09%   +0.01%     
==========================================
  Files         650      650              
  Lines       22887    22887              
  Branches     4122     4122              
==========================================
+ Hits        18558    18561       +3     
+ Misses       4267     4264       -3     
  Partials       62       62              
Impacted Files Coverage Δ
src/web3/saga.ts 78.43% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e35a5f...343f66f. Read the comment docs.

@kathaypacific kathaypacific enabled auto-merge (squash) February 10, 2023 15:17
Copy link
Member

@jeanregisser jeanregisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kathaypacific kathaypacific merged commit 04077a7 into main Feb 10, 2023
@kathaypacific kathaypacific deleted the kathy/update-lottie branch February 10, 2023 16:17
@valora-inc valora-inc deleted a comment from linear bot Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants